Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hover event bubbling #4071

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Fix hover event bubbling #4071

merged 1 commit into from
Dec 23, 2019

Conversation

Pessimistress
Copy link
Collaborator

For #4055

Change List

  • Do not call root onHover if a layer onHover callback returned true

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 80.859% when pulling 1c3560f on x/hover-bubble into 4f02eb9 on master.

@Pessimistress Pessimistress merged commit 8ee1ab9 into master Dec 23, 2019
@Pessimistress Pessimistress deleted the x/hover-bubble branch December 23, 2019 19:42
Pessimistress added a commit that referenced this pull request Dec 23, 2019
@Pessimistress
Fix hover event bubbling (#4071)
f9688c8
Pessimistress added a commit that referenced this pull request Dec 24, 2019
@Pessimistress
Fix hover event bubbling (#4071)
56747a5
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
Fix hover event bubbling (#4071)
da37bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@jianhuang01 jianhuang01 Awaiting requested review from jianhuang01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia