Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if initialViewState and viewState are both present #4078

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Warn if initialViewState and viewState are both present #4078

merged 1 commit into from
Jan 2, 2020

Conversation

Pessimistress
Copy link
Collaborator

For #4075

Change List

  • Log warning if both initialViewState and viewState are both specified
  • Add explanation to the upgrade guide

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 80.863% when pulling b3f8832 on x/viewstate-docs into e2b76a3 on master.

@Pessimistress Pessimistress merged commit 5c9b7c1 into master Jan 2, 2020
@Pessimistress Pessimistress deleted the x/viewstate-docs branch January 2, 2020 21:16
Pessimistress added a commit that referenced this pull request Jan 3, 2020
@Pessimistress
warn if initialViewState and viewState are both present (#4078)
7112cf3
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
warn if initialViewState and viewState are both present (#4078)
d3ed835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia