IconLayer: fix copy texture data when resize #4151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xintongxia
force-pushed
the
xx/icon-debug
branch
from
8582436 to
ebf0c93
Compare
test/render/test-cases.js
Outdated
| getIcon: d => { | ||
| if (d.PLACEMENT === 'SW') { | ||
| return { | ||
| url: './test/render/golden-images/pointcloud-meter.png', | ||
| url: './test/render/golden-images/examples/website_screen-grid.png', |
There was a problem hiding this comment.
Can we not use a golden image as icon? They may change in the future for reasons unrelated to this layer.
You can just reuse the marker pngs with a different id and size.
| width: 1024, | ||
| height: 1024, | ||
| anchorY: 1024, | ||
| mask: false | ||
| }; | ||
| }, | ||
| onAfterRender: ({layers, done}) => { |
There was a problem hiding this comment.
Is this why the test was failing? 😒
Pessimistress
approved these changes
Jan 15, 2020
xintongxia
pushed a commit
that referenced
this pull request
Jan 15, 2020
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
for #4146 and related to #4039
Change List