Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binary data in TextLayer #4206

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Support binary data in TextLayer #4206

merged 3 commits into from
Feb 4, 2020

Conversation

Pessimistress
Copy link
Collaborator

For #3758

cc @ajduberstein @twojtasz

Change List

  • Add binary support to TextLayer
  • Documentation
  • Unit and render tests

@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Coverage Status

Coverage increased (+2.5%) to 83.38% when pulling 12abfa4 on x/text-layer-binary into ff6f9ff on master.

@Pessimistress Pessimistress changed the base branch from x/text-layer to master January 28, 2020 22:22
@xintongxia
Copy link
Contributor

Why is this Port website examples to ocular gatsby website (#4033) included here?

Other than that, looks good to me.

@Pessimistress
Copy link
Collaborator Author

Why is this Port website examples to ocular gatsby website (#4033) included here?

Ah we force pushed to master to correct a commit message. I'll rebase.

@Pessimistress Pessimistress merged commit ddb68da into master Feb 4, 2020
@Pessimistress Pessimistress deleted the x/text-layer-binary branch February 4, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia