Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TerrainLayer loading experience #4312

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

Pessimistress
Copy link
Collaborator

For #4236

Change List

  • Only display a tile if both the mesh and the surface image are loaded
  • Fix an update issue in non-tiled scenario when terrainImage is changed
  • Restore no texture option in the demo

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 79.856% when pulling 78ed0d1 on x/terrain-optimize into add2cef on master.

Copy link
Collaborator

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool! Thanks for fixing the bugs.

I could see cases where either the old or the new loading experience is better. For example, it was nice to progressively load on slow connections so that something could be shown quickly. But it is a less ideal experience and could confuse users.

Was there a technical reason to load this way by any chance? I haven’t thought about it.

@Pessimistress
Copy link
Collaborator Author

Was there a technical reason to load this way by any chance?

TileLayer determines the visibility of tiles based on whether their data loaders are resolved.

@Pessimistress Pessimistress merged commit 6a65e73 into master Feb 26, 2020
@Pessimistress Pessimistress deleted the x/terrain-optimize branch February 26, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants