-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vector maps in google module #5981
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b04d8a2
Extend google overlay to support vector map
felixpalmer 17f314d
Workaround rendering bug after picking
felixpalmer 93456a4
Update viewport alignment doc
felixpalmer 0c4c19a
Rename lifecycle methods
felixpalmer d83b671
Add section on calculating the zoom factor
felixpalmer be525fc
Use altitude = focalDistance & scaled near plane
felixpalmer 873be8b
Set far to Infinity
felixpalmer 3fc4806
Undo infinity
felixpalmer a425566
Remove test files
felixpalmer 17527c2
Revert google app.js boilerplate
felixpalmer 162eb54
Fix tests for raster google map
felixpalmer 1e2fa06
Test lifecycle methods
felixpalmer 7f563d0
Draw & pick test for vector and raster
felixpalmer 75fa0ff
Don’t hardcode map id
felixpalmer 3b09dda
Comment on DOM depending on raster/vector
felixpalmer 0f9c8ca
Remove null defaults for matrices in view.js
felixpalmer b371272
Pass projectionMatrix directly to viewState
felixpalmer c63474b
Link to docs on Google Map ID
felixpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we define these methods in ES6 syntax? E.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't follow here. Are the methods
_onAdd
,_onContextRestored
etc not already using the correct syntax? We need to bind them to thegoogle.maps.WebglOverlayView
object as per Google's docs