Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website to work with ESM #8509

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fix website to work with ESM #8509

merged 3 commits into from
Feb 19, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Feb 19, 2024

Currently these changes allow the website to be ran locally using yarn start, but yarn build-staging fails.

In order to publish the website, instances to import GL from '@luma.gl/constants'; will need to be removed (to be done in followup PR)

Change List

  • Fix write-headings-id script
  • Remove inline-webgl-constants script

@felixpalmer felixpalmer marked this pull request as draft February 19, 2024 10:39
@felixpalmer felixpalmer added this to the v9.0 milestone Feb 19, 2024
@Pessimistress
Copy link
Collaborator

My understanding is that we won't have WebGL-specific constants in v9, therefore inline-webgl-constants can just be removed.

remove-glsl-comments should still work, though? It doesn't have any dependency on luma packages.

@felixpalmer
Copy link
Collaborator Author

@Pessimistress remove-glsl-comments was just missing from package.json

@felixpalmer felixpalmer marked this pull request as ready for review February 19, 2024 12:15
@felixpalmer felixpalmer merged commit 6d3b6d2 into master Feb 19, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/website-esm branch February 19, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants