Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Attribute.type to VertexType from WebGL constants #8572

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Change Attribute.type to VertexType from WebGL constants #8572

merged 3 commits into from
Mar 4, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Change List

  • DataColumn class handles the new type
  • Layer attribute definitions
  • Tests

@coveralls
Copy link

coveralls commented Mar 2, 2024 •
edited
Loading

Coverage Status

coverage: 70.676% (-0.008%) from 70.684%
when pulling 6927e36 on x/attribute-type
into d9902fb on master.

felixpalmer
felixpalmer approved these changes Mar 4, 2024
View reviewed changes
modules/core/src/lib/attribute/data-column.ts Outdated Show resolved Hide resolved
modules/core/src/lib/attribute/gl-utils.ts Outdated Show resolved Hide resolved
@Pessimistress Pessimistress merged commit 71c8fe4 into master Mar 4, 2024
3 checks passed
@Pessimistress Pessimistress deleted the x/attribute-type branch March 4, 2024 16:45
This was referenced Mar 7, 2024
Closed
Closed
This was referenced Mar 12, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@donmccurdy donmccurdy Awaiting requested review from donmccurdy

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @felixpalmer