-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geo-layers): Add .debounceTime option to Tileset2D, TileLayer #8589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @donmccurdy and the rest of your teammates on Graphite |
donmccurdy
force-pushed
the
donmccurdy/feat-tile-resolution
branch
from
March 7, 2024 16:20
e517113
to
5f67202
Compare
donmccurdy
force-pushed
the
donmccurdy/feat-tile-delay
branch
2 times, most recently
from
March 7, 2024 16:23
bfe4529
to
d4ae51d
Compare
donmccurdy
changed the base branch from
donmccurdy/feat-tile-resolution
to
donmccurdy/loaders-gl-v4.2.0-alpha.5
March 7, 2024 19:48
donmccurdy
force-pushed
the
donmccurdy/feat-tile-delay
branch
2 times, most recently
from
March 7, 2024 19:51
d61cbc2
to
fbefd1d
Compare
donmccurdy
force-pushed
the
donmccurdy/loaders-gl-v4.2.0-alpha.5
branch
from
March 8, 2024 14:41
dd8175b
to
09ca0b4
Compare
donmccurdy
force-pushed
the
donmccurdy/feat-tile-delay
branch
2 times, most recently
from
March 8, 2024 22:45
3d11bd7
to
53d4dd7
Compare
Update layer documentation too |
felixpalmer
approved these changes
Mar 11, 2024
donmccurdy
force-pushed
the
donmccurdy/feat-tile-delay
branch
from
March 11, 2024 17:50
a66220d
to
526b684
Compare
Added documentation and unit tests. The Tileset2D tests were not previously running, so I've re-enabled those and fixed most that were broken. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 'debounceTime' prop to TileLayer and Tileset2D. Queues tile requests until no new tiles have been requested for at least
debounceTime
milliseconds. Assuming this API and feature sound OK, I'll include docs and tests as well.Related: