Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo-layers): Add .debounceTime option to Tileset2D, TileLayer #8589

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Mar 6, 2024

Adds a 'debounceTime' prop to TileLayer and Tileset2D. Queues tile requests until no new tiles have been requested for at least debounceTime milliseconds. Assuming this API and feature sound OK, I'll include docs and tests as well.

Related:

@donmccurdy
Copy link
Collaborator Author

donmccurdy commented Mar 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @donmccurdy and the rest of your teammates on Graphite Graphite

@donmccurdy donmccurdy force-pushed the donmccurdy/feat-tile-resolution branch from e517113 to 5f67202 Compare March 7, 2024 16:20
@donmccurdy donmccurdy force-pushed the donmccurdy/feat-tile-delay branch 2 times, most recently from bfe4529 to d4ae51d Compare March 7, 2024 16:23
@donmccurdy donmccurdy changed the base branch from donmccurdy/feat-tile-resolution to donmccurdy/loaders-gl-v4.2.0-alpha.5 March 7, 2024 19:48
@donmccurdy donmccurdy force-pushed the donmccurdy/feat-tile-delay branch 2 times, most recently from d61cbc2 to fbefd1d Compare March 7, 2024 19:51
@donmccurdy donmccurdy force-pushed the donmccurdy/loaders-gl-v4.2.0-alpha.5 branch from dd8175b to 09ca0b4 Compare March 8, 2024 14:41
Base automatically changed from donmccurdy/loaders-gl-v4.2.0-alpha.5 to master March 8, 2024 14:48
@donmccurdy donmccurdy force-pushed the donmccurdy/feat-tile-delay branch 2 times, most recently from 3d11bd7 to 53d4dd7 Compare March 8, 2024 22:45
@donmccurdy donmccurdy marked this pull request as ready for review March 8, 2024 23:21
@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 82.909% (+0.3%) from 82.631%
when pulling 0b2e3c9 on donmccurdy/feat-tile-delay
into 375ef98 on master.

@Pessimistress
Copy link
Collaborator

Update layer documentation too

@donmccurdy donmccurdy force-pushed the donmccurdy/feat-tile-delay branch from a66220d to 526b684 Compare March 11, 2024 17:50
@donmccurdy
Copy link
Collaborator Author

Added documentation and unit tests. The Tileset2D tests were not previously running, so I've re-enabled those and fixed most that were broken. The Tileset2D#maxCacheByteSize test remains disabled for now.

@donmccurdy donmccurdy merged commit 401e7a6 into master Mar 11, 2024
2 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/feat-tile-delay branch March 11, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants