Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct operator precedence for clearColor in LayersPass #8599

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Correct operator precedence for clearColor in LayersPass #8599

merged 1 commit into from
Mar 7, 2024

Conversation

felixpalmer
Copy link
Collaborator

#8543 breaks MaskPass due to incorrect operator precedence causing clearColor to always be [0, 0, 0, 0]

Change List

  • Correct operator precedence for clearColor in LayersPass

@felixpalmer felixpalmer requested a review from donmccurdy March 7, 2024 15:23
@felixpalmer felixpalmer mentioned this pull request Mar 7, 2024
Merged
donmccurdy
donmccurdy approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch – good fix, thank you!

@felixpalmer felixpalmer merged commit 157aef8 into master Mar 7, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/layer-pass-clearColor branch March 7, 2024 15:27
@coveralls
Copy link

Coverage Status

coverage: 73.701%. remained the same
when pulling 9d1a334 on felix/layer-pass-clearColor
into 1676f8d on master.

@felixpalmer felixpalmer mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @donmccurdy