Fix FillStyleExtension artifact #8668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/fill-extension-fix
branch
from
eef3f02 to
0fc6506
Compare
felixpalmer
approved these changes
Mar 18, 2024
| minFilter: 'linear' | ||
| // Override default mipmap filter 'linear', i.e. set MIN_FILTER to LINEAR instead of LINEAR_MIPMAP_LINEAR | ||
| // @ts-expect-error invalid value for type `SamplerProps` - luma.gl should allow unset | ||
| mipmapFilter: '' |
There was a problem hiding this comment.
I wonder if it would be better to explicitly support mipmapFilter: 'none' in luma to make it clearer what is happening. None of the other SamplerProps allow falsy values
There was a problem hiding this comment.
I think lodMaxClamp: 0 would have the effect of disabling mips, if that's the goal? Luma is mirroring the WebGPU spec, in which all samplers have mipmapFilter, but you can restrict the range of mipmaps used with lodMinClamp / lodMaxClamp.
Opened PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default texture parameters sets
mipmapFilter: 'linear'and it cannot be unset by merging with anotherSamplePropsAlternatively we could remove it from the defaults but that will be a bigger breaking change.
Change List