Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mesh-layers): ScenegraphLayer picking #8752

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(mesh-layers): ScenegraphLayer picking #8752

merged 1 commit into from
Apr 4, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #8751

Change List

  • Remove ad-hoc handling of attributes/parameters/module settings; populate this.state.models to use the base layer's default behavior

Tested: website scenegraph example (instanced); documentation embedded example (animated); Google 3D tiles example (non-instanced)

@coveralls
Copy link

Coverage Status

coverage: 89.978% (-0.004%) from 89.982%
when pulling 9dc4188 on x/scenegraph-picking
into e6ef0bb on master.

@Pessimistress Pessimistress merged commit 479ebd1 into master Apr 4, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/scenegraph-picking branch April 4, 2024 14:59
Pessimistress added a commit that referenced this pull request Apr 4, 2024
@Pessimistress
fix(mesh-layers): ScenegraphLayer picking (#8752)
c3255c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @felixpalmer