Move ScatterplotLayer & BitmapLayer to UBOs #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
changed the title
ibgreen
approved these changes
May 7, 2024
modules/layers/src/scatterplot-layer/scatterplot-layer-inputs.ts
Outdated
Show resolved
Hide resolved
modules/layers/src/scatterplot-layer/scatterplot-layer-inputs.ts
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,11 @@ import * as FIXTURES from 'deck.gl-test/data'; | |||
|
|
|||
| const SIZE = 1; | |||
|
|
|||
| function getUniforms(layer: Layer) { | |||
There was a problem hiding this comment.
Thought: Maybe should be part of the layer test utils at some point?
modules/layers/src/scatterplot-layer/scatterplot-layer-inputs.ts
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,11 @@ import * as FIXTURES from 'deck.gl-test/data'; | |||
|
|
|||
| const SIZE = 1; | |||
|
|
|||
| function getUniforms(layer: Layer) { | |||
| // @ts-ignore | |||
| return layer.getModels()[0]._uniformStore.uniformBlocks.get('scatterplot').uniforms; | |||
There was a problem hiding this comment.
I believe you can do model.shaderInputs.getUniformValues()
There was a problem hiding this comment.
I figured it was better to check if the uniformStore as this is closer to the GPU
felixpalmer
commented
Jun 19, 2024
modules/layers/src/scatterplot-layer/scatterplot-layer-uniforms.ts
Outdated
Show resolved
Hide resolved
felixpalmer
commented
Jun 19, 2024
modules/layers/src/scatterplot-layer/scatterplot-layer-uniforms.ts
Outdated
Show resolved
Hide resolved
donmccurdy
approved these changes
Jun 21, 2024
felixpalmer
changed the title
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8782, trying out moving
ScatterplotLayer&BitmapLayerto use UBO.Change List
ShaderModulefor bindingscatterplot/bitmapuniformsshaderInputsrather thanuniformsindraw()layerUniformsmodule for setting layer opacity (allows removal ofsetUniforms())setUniformstemporarily kept to let tests pass (DataFilterExtensionand others still need this), will address in follow-up PRsMaskExtensionto use UBOs