Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PBR code to use luma pbrMaterial #9093

Merged
merged 10 commits into from
Aug 21, 2024
Merged

Update PBR code to use luma pbrMaterial #9093

merged 10 commits into from
Aug 21, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #8997.

Change List

  • Bump luma
  • Use new pbr_ variable names
  • New #ifdef LIGHTING_PBR instead on relying on module presence for feature detection
  • Fix I3S example (unrelated)

@felixpalmer felixpalmer requested a review from ibgreen August 20, 2024 09:53
@coveralls
Copy link

coveralls commented Aug 20, 2024 •
edited
Loading

Coverage Status

coverage: 89.196% (-0.02%) from 89.217%
when pulling 11ca071 on felix/pbr-ubo
into e101223 on master.

@felixpalmer felixpalmer merged commit beedfad into master Aug 21, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/pbr-ubo branch August 21, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @ibgreen