GPU Aggregation (7/8): ContourLayer #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Aug 23, 2024
ibgreen
approved these changes
Aug 23, 2024
|
|
||
| if (aggregator instanceof WebGLAggregator) { | ||
| const buffer = aggregator.getResult(channel)?.buffer; | ||
| if (buffer) { |
There was a problem hiding this comment.
Nit: Is there really no way of adding a getValueReader() type method to the aggregator interface so that we don't need this abstraction-breaking instanceof fiddling in the layers?
There was a problem hiding this comment.
I'm on the fence about this. This functionality is only really needed by this layer.
Pessimistress
force-pushed
the
x/aggregation-7
branch
from
ee060e8 to
54f40a2
Compare
Pessimistress
force-pushed
the
x/aggregation-7
branch
from
54f40a2 to
9829760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
Some golden images are updated because the default grid origin is moved from screen bottom-left to common space 0,0.
Change List
ContourLayerto use newAggregationLayerand aggregator classes