Match GlobeView projection parameters with Maplibre v5 #9201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
requested changes
Oct 4, 2024
| @@ -9,6 +9,9 @@ import {MapState, MapStateProps} from './map-controller'; | |||
| import {mod} from '../utils/math-utils'; | |||
| import LinearInterpolator from '../transitions/linear-interpolator'; | |||
|
|
|||
| // matches Web Mercator projection limit | |||
| const MAX_VALID_LATITUDE = 85.051129; | |||
There was a problem hiding this comment.
I wonder if math.gl shouldn't export this - it is used in a number of places
| @@ -9,6 +9,9 @@ import {MapState, MapStateProps} from './map-controller'; | |||
| import {mod} from '../utils/math-utils'; | |||
| import LinearInterpolator from '../transitions/linear-interpolator'; | |||
|
|
|||
| // matches Web Mercator projection limit | |||
| const MAX_VALID_LATITUDE = 85.051129; | |||
|
|
|||
There was a problem hiding this comment.
I'm seeing strange things when moving near the poles
Screen.Recording.2024-10-04.at.10.40.03.mov
|
|
||
| constructor(opts: GlobeViewportOptions = {}) { | ||
| const { | ||
| latitude = 0, | ||
| longitude = 0, | ||
| zoom = 0, | ||
| nearZMultiplier = 0.1, |
There was a problem hiding this comment.
Can you document somewhere how you updated these defaults? Is there some magic formula?
| @@ -275,7 +275,7 @@ const TEST_CASES = [ | |||
| viewState: { | |||
| longitude: -6, | |||
| latitude: 58, | |||
| zoom: 1.5 | |||
| zoom: 1.5 + 0.7353406094252244 // Math.log2(1 / Math.PI / Math.cos(58 / 180 * Math.PI)) | |||
There was a problem hiding this comment.
I feel it is better to update the image than having some weird constant here. There is a significant change in output anyway
| fovy = altitudeToFovy(altitude); | ||
| } | ||
| // Used to match globe and web mercator projection at high zoom | ||
| const scaleAdjust = 1 / Math.PI / Math.cos((latitude * Math.PI) / 180); |
There was a problem hiding this comment.
Worth guarding against division by 0? Despite this, the viewport could still be manually constructed with the pole value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9199
Grid lines are rendered by Maplibre, points are rendered by deck.gl.
Change List
GlobeViewport's scale, nearZ, farZ with maplibre'sGlobeTransformGlobeViewswitch toWebMercatorViewportat zoom>=12. maplibre performs interpolation between the two projections at z [11, 12]. We may need to do the same, but the difference is honestly very subtle.