Skip to content

fix(core): Enable shader/pipeline caching for attached WebGL devices #9971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisgervang merged 9 commits into from
Feb 4, 2026
Merged

fix(core): Enable shader/pipeline caching for attached WebGL devices #9971

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
de7b5f2
fix(core): Enable shader/pipeline caching for attached WebGL devices
michaelsaily Jan 28, 2026
d5382c4
Merge branch 'master' into fix/enable-caching-for-attached-devices
chrisgervang Jan 29, 2026
45c2ab7
Caching props moved below default deviceProps, to ensure caching alwa…
michaelsaily Jan 29, 2026
720f737
Merge remote-tracking branch 'fork/fix/enable-caching-for-attached-de…
michaelsaily Jan 29, 2026
4665384
Merge branch 'master' into fix/enable-caching-for-attached-devices
chrisgervang Jan 29, 2026
6e45bf6
Changes reverted:
michaelsaily Jan 29, 2026
eb86bd1
Merge remote-tracking branch 'fork/fix/enable-caching-for-attached-de…
michaelsaily Jan 29, 2026
2758433
Merge branch 'master' into fix/enable-caching-for-attached-devices
chrisgervang Feb 1, 2026
2a6bb54
Merge branch 'master' into fix/enable-caching-for-attached-devices
chrisgervang Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/core/src/lib/deck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@ export default class Deck<ViewsT extends ViewOrViews = null> {
const userOnResize = this.props.deviceProps?.onResize;

deviceOrPromise = webgl2Adapter.attach(props.gl, {
// Enable shader and pipeline caching for attached devices (matches _createDevice defaults)
// Without this, interleaved mode (e.g., MapboxOverlay) creates new pipelines every frame
_cacheShaders: true,
_cachePipelines: true,
Copy link
Collaborator

@chrisgervang chrisgervang Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this below the spread in case a user wants to customize their device props. By default deviceProps is a {} so the caching will still apply

Copy link
Contributor Author

@michaelsaily michaelsaily Jan 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much @chrisgervang! That's a great catch: I've gone ahead and made the required change. I've also gone ahead and manually verified the changes via the examples/basemap-browser that you had recommended, and can confirm that no regressions were found, having tested it across all integrations.

Just as a slight note for anyone else wanting to verify the change: I believe that the performance impact scales with scene complexity and interaction frequency. As the examples/basemap-browser are quite simple, the problem doesn't always seem apparent, though this quickly changes in production applications with greater complexity and data.

Copy link
Collaborator

@chrisgervang chrisgervang Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my apologies, I misread your code. Your original code allowed the user to customize the props and now it forces the caching. Let's revert to your original version, please.

Copy link
Collaborator

@chrisgervang chrisgervang Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to hear the example is working!

Copy link
Contributor Author

@michaelsaily michaelsaily Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hahaha, no worries! Changes reverted and pushed.

...this.props.deviceProps,
onResize: (canvasContext, info) => {
// Manually sync drawing buffer dimensions (canvas is externally managed)
Expand Down
Loading