fix(tile-converter): CesiumION tileset URL #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Jul 19, 2023
| @@ -240,10 +240,14 @@ export default class I3SConverter { | |||
|
|
|||
| try { | |||
| const preloadOptions = await this._fetchPreloadOptions(); | |||
| let tilesetUrl = inputUrl; | |||
There was a problem hiding this comment.
The code is a bit difficult to follow. I think it is partly because the existing helper function is called _fetchPreloadOptions but this update makes it clear that the main thing it returns a URL, and beyond that only the headers of the options are used.
_preloadURLAndHeaders() ?
There was a problem hiding this comment.
The response of prefetch:
There are other properties that we don't need
belom88
added a commit
that referenced
this pull request
Jul 21, 2023
dsavinov-actionengine
added
the
ActionEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.