chore(tile-converter): create SLPK hash during serve #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belom88
requested changes
Jul 25, 2023
modules/i3s/test/index.js
Outdated
| @@ -12,3 +12,4 @@ import './zip-utils/data-view-provider.spec'; | |||
| import './zip-utils/cd-file-header.spec'; | |||
| import './zip-utils/local-file-header.spec'; | |||
| import './search-from-the-end.spec'; | |||
| import './end-of-dentral-directory.spec'; | |||
There was a problem hiding this comment.
Suggested change
| import './end-of-dentral-directory.spec'; | |
| import './end-of-central-directory.spec'; |
| } | ||
| let hashData: HashElement[]; | ||
| if (cdFileHeader?.fileName !== '@specialIndexFileHASH128@') { | ||
| cb?.("SLPK doesn't contain hash file"); |
| import {ZipSignature, searchFromTheEnd} from './search-from-the-end'; | ||
| import {SLPKArchive} from './slpk-archieve'; | ||
| import {searchFromTheEnd} from '../parse-zip/search-from-the-end'; | ||
| import {HashElement, SLPKArchive, compareHashes} from './slpk-archieve'; | ||
|
|
||
| /** | ||
| * Creates slpk file handler from raw file | ||
| * @param fileProvider raw file data | ||
| * @returns slpk file handler | ||
| */ | ||
|
|
There was a problem hiding this comment.
remove empty line between comment and function
Comment on lines
148
to
151
| let data = await this.getFileBytes(path); | ||
| if (!data) { | ||
| data = await this.getFileBytes(path.toLocaleLowerCase()); | ||
| } |
There was a problem hiding this comment.
Datasets made by spec should work faster. As lowercase is by spec so it should work faster. I'd suggest to seek it first. If search by spec is not working the code will try to find it in another way.
Point it out in the comment with reference to the spec.
| @@ -9,6 +10,8 @@ export type ZipCDFileHeader = { | |||
| compressedSize: bigint; | |||
| /** Uncompressed size */ | |||
| uncompressedSize: bigint; | |||
| /** Extra field size size */ | |||
There was a problem hiding this comment.
misprint?
Suggested change
| /** Extra field size size */ | |
| /** Extra field size */ |
| CD_LOCAL_HEADER_OFFSET_OFFSET: 42n, | ||
| CD_FILE_NAME_OFFSET: 46n | ||
| }; | ||
| ): Promise<ZipCDFileHeader | undefined> => { |
There was a problem hiding this comment.
undefined is not a good type to return it explicitly. null is better
Suggested change
| ): Promise<ZipCDFileHeader | undefined> => { | |
| ): Promise<ZipCDFileHeader | null> => { |
| Buffer.from(signature) | ||
| ) !== 0 | ||
| ) { | ||
| return Promise.resolve(undefined); |
There was a problem hiding this comment.
Suggested change
| return Promise.resolve(undefined); | |
| return null; |
|
|
||
| /** | ||
| * Parses end of central directory record of zip file | ||
| * @param fileProvider - buffer containing whole array |
There was a problem hiding this comment.
Does it work only with array or with file handle as well?
Suggested change
| * @param fileProvider - buffer containing whole array | |
| * @param fileProvider - FileProvider instance |
| slpkArchive = await parseSLPK(await FileHandleProvider.from(fullLayerPath), (msg) => | ||
| console.log(msg) | ||
| ); | ||
| console.log('Server ready to use'); |
There was a problem hiding this comment.
Suggested change
| console.log('Server ready to use'); | |
| console.log('The server is ready to use'); |
belom88
approved these changes
Jul 26, 2023
dsavinov-actionengine
added
the
ActionEngine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.