feat(tiles): 3DTile services #2635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorDykhta
reviewed
Sep 8, 2023
|
|
||
| /** | ||
| * @see https://developers.google.com/maps/documentation/tile/policies | ||
| * attribution shouldn't be hidden (right now dataset attribution is only partly shown and expanded on hover). |
There was a problem hiding this comment.
These are Studio-related comments.
|
|
||
| /** Queries metadata from a 3D tileset service. | ||
| * @param url Url of a 3D tileset. | ||
| * @param this.accessToken Optional access token. |
There was a problem hiding this comment.
params are for the constructor above
| title: 'Built with Google Maps.', | ||
| url: '', | ||
| logoUrl: | ||
| 'https://developers.google.com/static/maps/documentation/images/google_on_non_white.png', |
There was a problem hiding this comment.
For Google we we need to place the attribution logo on our CDN.
igorDykhta
approved these changes
Sep 10, 2023
| const assetId = matched && matched[1]; | ||
| return assetId ? {assetId, resource: 'tileset.json'} : null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we need getLoadOptions here?
loadOptions: {'cesium-ion': {accessToken, worker: true}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@igorDykhta jamming on your code from the attribution PR...