GLTF: inline emod function to remove loaders.gl/math dependency #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Nit: While I really appreciate the effort to modularize, I feel that adding a dependency just for a one liner mod function is overkill. While tree shaking should take care of removing all the unused functions from production bundles, every dependency does make the library a little heavier to use.
In this case I would just copy the emod function over to the importing file and remove the dependency.
felixpalmer
changed the title
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, importing
@loaders.gl/gltffails (e.g. in luma.gl) due to this import: https://github.com/visgl/loaders.gl/blob/master/modules/gltf/src/lib/extensions/utils/3d-tiles-utils.ts#L17