Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version injection #2834

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: version injection #2834

merged 1 commit into from
Dec 11, 2023

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Dec 11, 2023 •
edited
Loading

  • ocular had moved all babel configs into a subfield, no typings meant no warnings.
  • this handles the subset of compilation that still goes through babel
  • worker builds e.g. rely on version injection through esbuild parameters.
  • scripts esbuild from babel transpiled source so they are OK for now.

@ibgreen ibgreen changed the title fix: Try to fix version injection fix: version injection Dec 11, 2023
@ibgreen ibgreen marked this pull request as ready for review December 11, 2023 21:44
@ibgreen ibgreen merged commit dcdc498 into master Dec 11, 2023
@ibgreen ibgreen deleted the ib/version branch December 11, 2023 21:59
ibgreen added a commit that referenced this pull request Feb 5, 2024
@ibgreen
fix: Fix version injection (#2834)
4f870fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilijapuaca ilijapuaca Awaiting requested review from ilijapuaca

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibgreen