fix(loader-utils): concatenateArrayBuffers bottleneck fix #2856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got the
RangeError: Maximum call stack size exceeded
error for huge slpk creation. So I investigated and found out that we have a bottleneck on the current implementation of concatenateArrayBuffers function in amount of arguments. I haven't found any info about nodejs, but I've found the following article: https://stackoverflow.com/a/22747272 and it looks like node has the same limitation of max 65 535 arguments per function and throw the same error since it use the same V8 engine to interpret JS code. But number of files even in 5gb datasets can reach 800 000, so node can't handle it and throws an error.To solve this problem I've created another function receiving
ArrayBuffer[]
instead of multiple arguments