Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i3s-scene-parser): provide unsupported layer types in the exception #2863

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

mspivak-actionengine
Copy link
Collaborator

No description provided.

@mspivak-actionengine mspivak-actionengine marked this pull request as ready for review January 24, 2024 12:49
@@ -26,6 +26,16 @@ const SUPPORTED_LAYERS_TYPES = [
const NO_AVAILABLE_SUPPORTED_LAYERS_ERROR = 'NO_AVAILABLE_SUPPORTED_LAYERS_ERROR';
const NOT_SUPPORTED_CRS_ERROR = 'NOT_SUPPORTED_CRS_ERROR';

class LayerError extends Error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some TSDocs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSDocs added.
One more change - the LayerError is exported so it's available in the I3s-explorer where the exception is being handled.

@mspivak-actionengine mspivak-actionengine merged commit 27f6384 into master Jan 30, 2024
4 checks passed
@mspivak-actionengine mspivak-actionengine deleted the ms/exception-unsupported-layer branch January 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants