Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zip): zip composition feature integration #2871

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

dariaterekhova-actionengine
Copy link
Collaborator

Integration of own algorithm to compose slpk in order to get rid of zip/7zip console archivers usage

@dariaterekhova-actionengine dariaterekhova-actionengine requested review from belom88 and ibgreen and removed request for belom88 January 30, 2024 12:32
@ibgreen ibgreen changed the title chore(zip): zip compozition feature integration chore(zip): zip composition feature integration Jan 30, 2024
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please run yarn test browser to check that all tests work.

To be specific, I had problems:

  • with node imports in the last zip PR test cases.
  • with zip module creating a NodeFileSystem in global scope, even on the browser

@dariaterekhova-actionengine dariaterekhova-actionengine merged commit d6d48f8 into master Jan 30, 2024
4 checks passed
@dariaterekhova-actionengine dariaterekhova-actionengine deleted the dt/zip-composition-integration branch January 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants