Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(i3s examples): add i3s colorization by attributes #2887

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

maxkuznetsov-actionengine
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@belom88 belom88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too large for an example.
I'd just have a dropdown with attributes to colorize. We don't need to have histogram, set of icons, picking and so on.
Could we make colorization and i3s removal in different PRs?

@dsavinov-actionengine
Copy link
Collaborator

dsavinov-actionengine commented Feb 19, 2024

This is too large for an example. I'd just have a dropdown with attributes to colorize. We don't need to have histogram, set of icons, picking and so on. Could we make colorization and i3s removal in different PRs?

  1. For the UI, would you both @maxkuznetsov-actionengine @belom88 agree with this?
    image

For Colorize Mode: None/Replace/Multiply
For Colorize Attribute: None/Selected Attribute
None is default for both

  1. Splitting in 2 different PRs - ok.

@belom88
Copy link
Collaborator

belom88 commented Feb 20, 2024

This is too large for an example. I'd just have a dropdown with attributes to colorize. We don't need to have histogram, set of icons, picking and so on. Could we make colorization and i3s removal in different PRs?

  1. For the UI, would you both @maxkuznetsov-actionengine @belom88 agree with this?
    image

For Colorize Mode: None/Replace/Multiply For Colorize Attribute: None/Selected Attribute None is default for both

  1. Splitting in 2 different PRs - ok.

I suggest swiping controls. User selects from top to down direction. 1st - select attribute, 2nd - select mode (if needed)

@maxkuznetsov-actionengine maxkuznetsov-actionengine changed the title chore(i3s examples): replace i3s example by i3s colorization chore(i3s examples): add i3s colorization by attributes Feb 20, 2024
@maxkuznetsov-actionengine maxkuznetsov-actionengine merged commit 3930317 into master Feb 28, 2024
3 checks passed
@maxkuznetsov-actionengine maxkuznetsov-actionengine deleted the i3s_colorization_example branch February 28, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants