Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Add I3S Picking Tutorial #2896

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

maxkuznetsov-actionengine
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining the inline code may take a bit of maintenance in the future, as it is not directly linked. Have a similar situation in luma.gl v9, all the tutorials there are now outdated.

"whats-new",
"upgrade-guide"
]
"items": ["README", "developer-guide/get-started", "whats-new", "upgrade-guide"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we understand why the layout of this file suddenly changed? Modifications further down somehow triggered prettier?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's changed by prettier after saving other changes.
Do you want to revert it back?


To get attributes data for the selected object it needs to invoke `loadFeatureAttributes` with the selected object and object's index as a params.

```javascript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```javascript
```ts

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

<p></p>
At the example above you can click any interesting object to get it highlighted and show selected object attributes data.
Objects picking can be implemented for `3DObject` layer type only, it's not applicable for `IntegratedMesh` layer type.
Please find source code of the example <a href="https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking">here</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please find source code of the example <a href="https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking">here</a>
Please find source code of the example [here](https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


import Demo from 'examples/website/i3s-picking/src/app';

<div style={{height: '50vh'}}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rename to *.mdx as it has React?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

@dsavinov-actionengine
Copy link
Collaborator

Maintaining the inline code may take a bit of maintenance in the future, as it is not directly linked. Have a similar situation in luma.gl v9, all the tutorials there are now outdated.

We link directly to the appropriate example so it shouldnt be a problem. Only the code snippets are in tutorial - those we will keep up-to-date.

@dsavinov-actionengine
Copy link
Collaborator

@ibgreen could you please re-review when you have spare time. We'd like to finish with this until 29th Feb.

@maxkuznetsov-actionengine maxkuznetsov-actionengine merged commit 59db089 into master Feb 28, 2024
3 checks passed
@maxkuznetsov-actionengine maxkuznetsov-actionengine deleted the i3s_picking_tutorial branch February 28, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants