-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Add I3S Picking Tutorial #2896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintaining the inline code may take a bit of maintenance in the future, as it is not directly linked. Have a similar situation in luma.gl v9, all the tutorials
there are now outdated.
"whats-new", | ||
"upgrade-guide" | ||
] | ||
"items": ["README", "developer-guide/get-started", "whats-new", "upgrade-guide"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we understand why the layout of this file suddenly changed? Modifications further down somehow triggered prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's changed by prettier after saving other changes.
Do you want to revert it back?
docs/modules/i3s/recipes/picking.md
Outdated
|
||
To get attributes data for the selected object it needs to invoke `loadFeatureAttributes` with the selected object and object's index as a params. | ||
|
||
```javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
```javascript | |
```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/modules/i3s/recipes/picking.md
Outdated
<p></p> | ||
At the example above you can click any interesting object to get it highlighted and show selected object attributes data. | ||
Objects picking can be implemented for `3DObject` layer type only, it's not applicable for `IntegratedMesh` layer type. | ||
Please find source code of the example <a href="https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking">here</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find source code of the example <a href="https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking">here</a> | |
Please find source code of the example [here](https://github.com/visgl/loaders.gl/tree/master/examples/website/i3s-picking) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
docs/modules/i3s/recipes/picking.md
Outdated
|
||
import Demo from 'examples/website/i3s-picking/src/app'; | ||
|
||
<div style={{height: '50vh'}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we rename to *.mdx as it has React?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed
We link directly to the appropriate example so it shouldnt be a problem. Only the code snippets are in tutorial - those we will keep up-to-date. |
@ibgreen could you please re-review when you have spare time. We'd like to finish with this until 29th Feb. |
No description provided.