chore(docs): Update tile-converter.md #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo and grammar minor fixes
belom88
requested changes
Sep 12, 2024
Co-authored-by: Viktor Belomestnov <belom88@yandex.ru>
added notes that 7z and slpk are deprecated now
belom88
requested changes
Oct 30, 2024
| | slpk | \* | | Whether the converter generates \*.slpk (Scene Layer Package) I3S output files | | ||
| | 7zExe | \* | | location of 7z.exe archiver to create slpk on Windows OS, default: "C:\\Program Files\\7-Zip\\7z.exe" | | ||
| | egm | \* | \* | location of the Earth Gravity Model (\*.pgm) file to convert heights from ellipsoidal to gravity-related format or "None" to not use it, default: "./deps/egm2008-5.pgm". A model file can be loaded from GeographicLib https://geographiclib.sourceforge.io/html/geoid.html | | ||
| | slpk | \* | | (Deprecated since version 4.3.0) <br> Whether the converter generates \*.slpk (Scene Layer Package) I3S output files. Note: For versions 4.3.0 and up \*.slpk is the default output wihtout this option specified. | |
There was a problem hiding this comment.
Suggested change
| | slpk | \* | | (Deprecated since version 4.3.0) <br> Whether the converter generates \*.slpk (Scene Layer Package) I3S output files. Note: For versions 4.3.0 and up \*.slpk is the default output wihtout this option specified. | | |
| | slpk | \* | | (Deprecated since version 4.3.0) <br /> Whether the converter generates \*.slpk (Scene Layer Package) I3S output files. Note: For versions 4.3.0 and up the option doesn't work, \*.slpk is the only possible output of I3S. | |
There was a problem hiding this comment.
The option --slpk is removed from npx tile-converter --help. we should add this information back
There was a problem hiding this comment.
Where should it be brought back? I mean where is the help text located? Can you send file path here?
There was a problem hiding this comment.
There was a problem hiding this comment.
Brought it back there.
| | 7zExe | \* | | location of 7z.exe archiver to create slpk on Windows OS, default: "C:\\Program Files\\7-Zip\\7z.exe" | | ||
| | egm | \* | \* | location of the Earth Gravity Model (\*.pgm) file to convert heights from ellipsoidal to gravity-related format or "None" to not use it, default: "./deps/egm2008-5.pgm". A model file can be loaded from GeographicLib https://geographiclib.sourceforge.io/html/geoid.html | | ||
| | slpk | \* | | (Deprecated since version 4.3.0) <br> Whether the converter generates \*.slpk (Scene Layer Package) I3S output files. Note: For versions 4.3.0 and up \*.slpk is the default output wihtout this option specified. | | ||
| | 7zExe | \* | | (Deprecated since version 4.1.0) <br> location of 7z.exe archiver to create slpk on Windows OS, default: "C:\\Program Files\\7-Zip\\7z.exe". Note: For versions 4.1.0 and up 7z is not needed and tile-converter uses internal zip module instead. | |
There was a problem hiding this comment.
This option is removed. Remove it from the docs
There was a problem hiding this comment.
Is it removed for 4.0.x and below? I thought maybe old versions need this option
There was a problem hiding this comment.
"Deprecated" means "You can use it, but it is not recommended". The options is removed and we cannot use it. May be "(Removed since version 4.1.0)" is better
There was a problem hiding this comment.
Added as "(Removed since version 4.1.0)"
texture is presented > texture is present
belom88
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo and grammar minor fixes