Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @types/brotli also optional #3152

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

newyankeecodeshop
Copy link
Contributor

The types for brotli include a depenency on @types/node. For a web-based user of deck.gl, loaders.gl, and which does not use the brotli library, this adds the node type globals into the type system. That creates some unfortunate inconsistencies with Web/DOM global types.

Since brotli is optional, the types can also be optional so that both can be excluded from environments that don't use them.

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 31, 2024

@newyankeecodeshop I think this is fine, as we don't really expose the brotli API to apps (usage is wrapped in the compression class).

But perhaps we can add the brotli types to devDependencies so that we keep the benefits of type checking while building loaders.gl?

@ibgreen ibgreen merged commit 3ab47cd into visgl:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants