Mapbox Vector Tiles loader

[jesusbotella]

As we talked in visgl/deck.gl#3935, here's the pull request for MapboxVectorTiles loader code. I followed your steps and added some other things for the tests.

I have two doubts about this right now:

• I have set parse and parseSync methods but the executed code is synchronous as I assumed that the first parameter within the function should be the MVT array buffer. So I don't know if I should remove parseSync as parse will do already.

• Tests are not passing because I didn't include a loader for MVT. Should I include raw-loader for MVT as it is a binary format? I have never had to require an MVT file through webpack, so I should research that a little.

These are my concerns right now. I'd need to see how load method works so that I can be sure that the attributes passed to parse function are the ones I assumed it would have.

Thank you!

[claassistantio]

All committers have signed the CLA.

[ibgreen]

@jesusbotella Thanks, this looks great. I will take over from here.

I have set parse and parseSync methods but the executed code is synchronous as I assumed that the first parameter within the function should be the MVT array buffer. So I don't know if I should remove parseSync as parse will do already.

Correct, parseSync is optional. However, by providing loader.parseSync you enable synchronous parsing using parseSync(arrayBuffer, MVTLoader) which can be nice to have since it does not involve promises etc.

So the reasons for this design is that not all loaders can do synchronous parsing, but it can be simpler to use when available. The reason we still need parse (which can be implemented by calling parseSync when available is that we wanted all loader objects to always have one function, parse.

Tests are not passing because I didn't include a loader for MVT. Should I include raw-loader for MVT as it is a binary format? I have never had to require an MVT file through webpack, so I should research that a little.

Tests should should work, as webpack-dev-server serves the local files during testing. You need to make sure the new module is listed in test/aliases.js

[ibgreen]

Typo "commercial"