WIP quantized mesh skirting #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR for adding skirts client side to meshes generated from Quantized Mesh terrain tiles. As described in the Quantized Mesh spec, the file format includes buffers designating the indices on each edge, so we don't have to loop through the positions to find them.
At least now I can clearly see my skirt from below:
But I might still have some indexing or winding order issues; edge lines are clearly visible still from above.
The open skirting PR on the Martini repo was a helpful reference: mapbox/martini#12
cc @chrisgervang