fix(webgl): Update video texture bindings before draw (#1853)

visgl · Nov 30, 2023 · 42a1c87 · 42a1c87
1 parent ecfcc1a
commit 42a1c87
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/modules/webgl/src/adapter/resources/webgl-render-pipeline.ts b/modules/webgl/src/adapter/resources/webgl-render-pipeline.ts
@@ -44,8 +44,6 @@ export class WEBGLRenderPipeline extends RenderPipeline {
   /** WebGL varyings */
   varyings: string[] | null = null;
 
-  _textureUniforms: Record<string, any> = {};
-  _textureIndexCounter: number = 0;
   _uniformCount: number = 0;
   _uniformSetters: Record<string, Function> = {}; // TODO are these used?
 
@@ -348,16 +346,9 @@ export class WEBGLRenderPipeline extends RenderPipeline {
   _areTexturesRenderable() {
     let texturesRenderable = true;
 
-    for (const [, texture] of Object.entries(this._textureUniforms)) {
-      texture.update();
-      texturesRenderable = texturesRenderable && texture.loaded;
-    }
-
     for (const [, texture] of Object.entries(this.bindings)) {
-      // texture.update();
-      // @ts-expect-error
-      if (texture.loaded !== undefined) {
-        // @ts-expect-error
+      if (texture instanceof WEBGLTexture) {
+        texture.update();
         texturesRenderable = texturesRenderable && texture.loaded;
       }
     }