Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core/multipass, main, wip folder #1278

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Remove core/multipass, main, wip folder #1278

merged 3 commits into from
Oct 14, 2019

Conversation

tsherif
Copy link
Contributor

@tsherif tsherif commented Oct 11, 2019

Second round of cleanup:

  • Remove core/multipass classes. The ones that are used in the glfx example have been moved there so the example still works.
  • Remove effects/experimental/passes. They were unused and depended on core/multipass
  • Remove main module and fix tests that were using it.
  • Remove glfx module (it was just an alias for effects)
  • Remove wip folder

Core Bundle Size

Before After Improvement
296kB 291kB 5kB (1%)

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 61.553% when pulling c6ee9e8 on multipass-cleanup into 1885867 on master.

@tsherif tsherif merged commit f9a2525 into master Oct 14, 2019
@tsherif tsherif deleted the multipass-cleanup branch October 14, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants