Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Remove dev-modules/ from yarn workspace #1889

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore(dev): Remove dev-modules/ from yarn workspace #1889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8624247
chore(dev): Remove dev-modules/ from yarn workspace
donmccurdy Dec 19, 2023
402715f
Clean up.
donmccurdy Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions babel.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ const plugins = [
// on it. This plugin uses LOCAL `@luma.gl/constants`, and will fail without
// it, so delay using the plugin until reaching a package depending on constants.
if (pkg.dependencies && '@luma.gl/constants' in pkg.dependencies) {
// TODO(v9): CI builds are flaky with this enabled, need to investigate cause.
// plugins.push('./dev-modules/babel-plugin-remove-glsl-comments/index.js');
// plugins.push('babel-plugin-inline-webgl-constants');
plugins.push('babel-plugin-inline-webgl-constants');
}

module.exports = getBabelConfig({
Expand Down
6 changes: 2 additions & 4 deletions dev-modules/babel-plugin-inline-webgl-constants/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "babel-plugin-inline-webgl-constants",
"private": true,
"version": "9.0.0-alpha.47",
"version": "2.0.0-alpha.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just publish 2.0.0, 2.01, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! I've used the version strings that are already published but it could make sense to do a stable publish for each, either here or after moving into a separate repo if we prefer.

"description": "Babel plugin for replacing long gl constants with the shorter corresponding numbers",
"type": "module",
"license": "MIT",
Expand All @@ -26,6 +25,5 @@
},
"dependencies": {
"@luma.gl/constants": "9.0.0-alpha.47"
},
"gitHead": "c636c34b8f1581eed163e94543a8eb1f4382ba8e"
}
}
6 changes: 2 additions & 4 deletions dev-modules/babel-plugin-remove-glsl-comments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "babel-plugin-remove-glsl-comments",
"private": true,
"version": "9.0.0-alpha.47",
"version": "1.0.0",
"description": "Babel plugin for removing glsl comments",
"license": "MIT",
"repository": {
Expand All @@ -16,6 +15,5 @@
"main": "index.js",
"dependencies": {
"minimatch": "^3.0.0"
},
"gitHead": "c636c34b8f1581eed163e94543a8eb1f4382ba8e"
}
}
6 changes: 2 additions & 4 deletions dev-modules/eslint-plugin-luma-gl-custom-rules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
{
"name": "eslint-plugin-luma-gl-custom-rules",
"private": "true",
"version": "9.0.0-alpha.47",
"main": "index.cjs",
"gitHead": "c636c34b8f1581eed163e94543a8eb1f4382ba8e"
"version": "9.0.0-alpha.17",
"main": "index.cjs"
}
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
],
"workspaces": [
"examples/*/*",
"dev-modules/*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this was the critical problem, I assume, that mysteriously linked everything together...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hopeful that ocular-publish will ignore these packages now, but if not we will see errors the next time we try to do a monorepo publish, just a heads up! (Not sure how to safely test that step ahead of time...)

"modules/*"
],
"browser": {
Expand Down
Loading