feat(gltf) Improve model positioning by considering worldMatrix #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
reviewed
Dec 20, 2023
| const far = 2 * this.vantage[0]; | ||
| const near = far / 1000; | ||
| const projectionMatrix = new Matrix4().perspective({fovy: Math.PI / 3, aspect, near, far}); | ||
| const vantage = [this.vantage[0] * Math.sin(0.001 * time), this.vantage[1], this.vantage[2] * Math.cos(0.001 * time)]; |
There was a problem hiding this comment.
Is vantage what I often call eyePostition?
There was a problem hiding this comment.
this.vantage is a position in the coordinate space of the model which should give a good viewing position. It is then rotated about the origin to provide the animation. This is a bit dubious as it assumes the model to have its center at the origin also
|
|
||
| this.scenes[0].traverse((node, {worldMatrix}) => { | ||
| const {model} = (node as ModelNode); | ||
|
|
||
| const eye = worldMatrix.transformAsPoint(vantage); |
There was a problem hiding this comment.
Q: Does it feel like the ScenegraphNode hierarchy should have a SceneNode sublcass that does some of these things, so that apps can use gltf models with a bit less work?
There was a problem hiding this comment.
SceneNode.getViewUniforms(): {u_Camera, u_MVPMatrix, u_ModelMatrix, u_NormalMatrix} could be nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1847
Background
Loading in large models led to a black screen as they were positioned outside viewport.
Change List