Changed type of channel to number

visgl · Oct 23, 2024 · ecf822a · ecf822a
1 parent 403c2cf
commit ecf822a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/docs/api-reference/components/api-provider.md b/docs/api-reference/components/api-provider.md
@@ -167,4 +167,4 @@ The following hooks are built to work with the `APIProvider` Component:
 [gmp-solutions-usage]: https://developers.google.com/maps/reporting-and-monitoring/reporting#solutions-usage
 [api-provider-src]: https://github.com/visgl/react-google-maps/blob/main/src/components/api-provider.tsx
 [rgm-new-issue]: https://github.com/visgl/react-google-maps/issues/new/choose
-[gmp-channel-usage]: https://developers.google.com/maps/reporting-and-monitoring/reporting#usage-tracking-per-channel
+[gmp-channel-usage]: https://developers.google.com/maps/reporting-and-monitoring/reporting#usage-tracking-per-channel
diff --git a/src/components/api-provider.tsx b/src/components/api-provider.tsx
@@ -74,10 +74,10 @@ export type APIProviderProps = {
    * empty string. Read more in the
    * [documentation](https://developers.google.com/maps/reporting-and-monitoring/reporting#solutions-usage).
    */
-  channel?: string;
+  channel?: number;
   /**
    * To track usage of Google Maps JavaScript API via numeric channels. The only acceptable channel values are numbers from 0-999.
-   * Read more in the 
+   * Read more in the
    * [documentation](https://developers.google.com/maps/reporting-and-monitoring/reporting#usage-tracking-per-channel)
    */
   solutionChannel?: string;
@@ -179,7 +179,11 @@ function useGoogleMapsApiLoader(props: APIProviderProps) {
           if (version) params.v = version;
           if (librariesString?.length > 0) params.libraries = librariesString;
 
-          if (params.channel === undefined || params.channel === '')
+          if (
+            params.channel === undefined ||
+            params.channel < 0 ||
+            params.channel > 999
+          )
             delete params.channel;
 
           if (params.solutionChannel === undefined)

diff --git a/src/libraries/google-maps-api-loader.ts b/src/libraries/google-maps-api-loader.ts
@@ -6,7 +6,7 @@ export type ApiParams = {
   language?: string;
   region?: string;
   libraries?: string;
-  channel?: string;
+  channel?: number;
   solutionChannel?: string;
   authReferrerPolicy?: string;
 };
@@ -140,7 +140,7 @@ export class GoogleMapsApiLoader {
             /[A-Z]/g,
             t => '_' + t[0].toLowerCase()
           );
-          urlParams.set(urlParamName, value);
+          urlParams.set(urlParamName, String(value));
         }
         urlParams.set('loading', 'async');
         urlParams.set('callback', '__googleMapsCallback__');