Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Popup and GeolocateControl under React StrictMode #1836

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Fix Popup and GeolocateControl under React StrictMode #1836

merged 2 commits into from
Apr 21, 2022

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Apr 20, 2022 •
edited
Loading

For #1825

Handle double useEffect calls under strict mode

Change List

  • Popup onOpen fires only once
  • Popup onClose no longer fires if the popup is closed by unmounting
  • GeolocateControl renders correctly in strict mode
  • Clarify callback behavior in Popup's documentation
  • Update the "controls" example to reflect recommended practice
  • Bump mapbox-gl dev dependency to latest

Todo

  • Update React dev dependency to v18

@Pessimistress Pessimistress merged commit 1c39128 into master Apr 21, 2022
@Pessimistress Pessimistress deleted the x/strictmode branch April 21, 2022 18:57
Pessimistress added a commit that referenced this pull request Apr 21, 2022
@Pessimistress
Fix Popup and GeolocateControl under React StrictMode (#1836)
40da7db
@Pessimistress Pessimistress mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @kylebarron