Support external GL context #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
I have overridden the mapbox context in the past however I am not sure if I tried to return a WebGL2 context.
The main problem I foresee with a WebGL2 context is that it does not support WebGL1 extensions, so if mapbox depends on certain WebGL extensions we'd have to polyfill them (or we might see reduced functionality/performance).
src/mapbox/mapbox.js
Outdated
| const getContext = HTMLCanvasElement.prototype.getContext; | ||
| if (props.gl) { | ||
| // Hijack canvas.getContext to return our own WebGLContext | ||
| HTMLCanvasElement.prototype.getContext = () => props.gl; |
There was a problem hiding this comment.
Suggest unhijacking as soon as done...
added 2 commits
September 26, 2018 15:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For visgl/deck.gl#2132