Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vlan filter match and action #1035

Closed
wants to merge 1 commit into from
Closed

Conversation

wangling94
Copy link

  1. filter match support vlanId and srcMac, dstMac.
  2. filter action support vlan pop/push.

@wangling94
Copy link
Author

refer commit of shuowang123, but fix some problem like when show a flower with vlan match, filter.EthType is missing. test on server
#810
#809

@wangling94
Copy link
Author

uname -r
3.10.0-693.21.7.el7.x86_64
ip -V
ip utility, iproute2-ss130716
test on server with CX5

@wangling94
Copy link
Author

trigger check rerun

@wangling94 wangling94 reopened this Dec 26, 2024
@wangling94 wangling94 closed this Dec 26, 2024
@wangling94
Copy link
Author

re run

@wangling94
Copy link
Author

@aboch
Sorry to bother you, I've identified the issue causing intermittent failures in the CI and have attempted to fix it in my PR. Could you please review it when you have a moment?

@aboch
Copy link
Collaborator

aboch commented Dec 26, 2024

@wangling94 you are not bothering at all.

This project follows a one change/fix/feature per commit per PR.
Please open a dedicated PR for the UT fix and one for the new vlan filter functionality.

Thank you for your contributions

@wangling94
Copy link
Author

@wangling94 you are not bothering at all.

This project follows a one change/fix/feature per commit per PR. Please open a dedicated PR for the UT fix and one for the new vlan filter functionality.

Thank you for your contributions

Thank you for reminding that, i have move UT fix to #1043

2. filter action support vlan pop/push.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants