Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): setup YAML Lint step #68

Merged
merged 12 commits into from
Feb 5, 2023
Merged

Conversation

mmorel-35
Copy link
Contributor

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

@mmorel-35 mmorel-35 changed the title ci(lint): setup Yamllint step ci(lint): setup YAML Lint step Feb 4, 2023
@mmorel-35 mmorel-35 marked this pull request as ready for review February 4, 2023 09:00
Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question... I personally tend to prefer some of these comments as inline, since they're distracting to folks who know what these params do, but helpful to provide more info for those who don't and need a little more hints.

Also, curious what prompted you to do this? It's nice, but we don't have that much yaml in here... was your editor yelling at you about it?

.github/dependabot.yml Show resolved Hide resolved
go mod tidy
git diff --exit-code
- name: Test
run: go test -exec "sudo -n" -v ./...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these formatting changes are all nice improvements 👍

@jeffwidman
Copy link
Collaborator

Can you squash your commits?

@mmorel-35
Copy link
Contributor Author

Can you squash your commits?

I'll do that when I can access a computer, within two days

@jeffwidman
Copy link
Collaborator

No worries, I can just squash when merging.

Also, in the future, if you don't have a computer where you can locally git clone a repo to, you can also just use a codespace: https://github.com/features/codespaces

I only recently discovered them myself, and while I still prefer more advanced coding on my local laptop, for quick changes, esp git commit changes, the codespaces are incredibly convenient.

Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants