-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(lint): setup YAML Lint step #68
Conversation
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question... I personally tend to prefer some of these comments as inline, since they're distracting to folks who know what these params do, but helpful to provide more info for those who don't and need a little more hints.
Also, curious what prompted you to do this? It's nice, but we don't have that much yaml in here... was your editor yelling at you about it?
go mod tidy | ||
git diff --exit-code | ||
- name: Test | ||
run: go test -exec "sudo -n" -v ./... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these formatting changes are all nice improvements 👍
Can you squash your commits? |
I'll do that when I can access a computer, within two days |
No worries, I can just squash when merging. Also, in the future, if you don't have a computer where you can locally I only recently discovered them myself, and while I still prefer more advanced coding on my local laptop, for quick changes, esp git commit changes, the codespaces are incredibly convenient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this!
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com