Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding file path for nerdctl and finch #87

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

Shubhranshu153
Copy link
Contributor

Adding the paths for pidfile for enabling usage with nerdctl and finch.

@Shubhranshu153
Copy link
Contributor Author

Also wanted to check a couple of things

  1. want to update the go version as the one here is old.
  2. Any plans for releasing a stable 1.0 version?

Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems fine to me to add nerdctl/finch, but I'm curious... can you please explain your use case?

Re: your other questions--they're good/valid questions, but should be discussed as distinct issues with dedicated threads, not as a distraction from the code change in this PR.

Thanks!

go.mod Outdated
@@ -1,5 +1,5 @@
module github.com/vishvananda/netns

go 1.17
go 1.22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in a separate PR as it's orthogonal to the primary intent of the PR. Also, please don't bump the go version... it means different things in the context of a library than it does in your app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack will remove this

@Shubhranshu153
Copy link
Contributor Author

it seems fine to me to add nerdctl/finch, but I'm curious... can you please explain your use case?

Re: your other questions--they're good/valid questions, but should be discussed as distinct issues with dedicated threads, not as a distraction from the code change in this PR.

Thanks!

nerdctl uses this package for netns, for finch one of our customer requested it for their systems which uses nerdctl to create a container and have a custom network namespace the container connects to.

Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
@Shubhranshu153
Copy link
Contributor Author

moved the other questions to issues.

Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jeffwidman
Copy link
Collaborator

LGTM... longterm it seems weird to have hardcoded paths in here rather than an interface that the user can override a set of defaults, but for now it's fine I think... it's not like this list is growing exponentially!

@jeffwidman jeffwidman merged commit 4c46424 into vishvananda:master Aug 13, 2024
8 checks passed
@Shubhranshu153
Copy link
Contributor Author

@jeffwidman Will it be possible to release a 0.5.0 for this commit, tagging it to a version seems easier to pull and use.
Not sure the steps here for a release.

@jeffwidman
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants