Backout some expression changes that are causing some test suite failures. #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brugger1
added a commit
that referenced
this pull request
Sep 17, 2019
brugger1
added a commit
that referenced
this pull request
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I removed some expression changes from last week that are causing some test suite failures.
Type of change
How Has This Been Tested?
I ran the test suite on the commit just before these changes and the tests passed and then when I ran the test suite on the commit with these changes a few tests failed. I haven't actually tested the backed out changes though. We'll find out tonight on that.
Checklist: