-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hover on orphan node #50
Conversation
thanks for the contribution @Tav0! will take a look at this |
@@ -5,7 +5,8 @@ var nodes = new vis.DataSet([ | |||
{ id: 2, label: 'Node 2', title: 'I have a popup!' }, | |||
{ id: 3, label: 'Node 3', title: 'I have a popup!' }, | |||
{ id: 4, label: 'Node 4', title: 'I have a popup!' }, | |||
{ id: 5, label: 'Node 5', title: 'I have a popup!' } | |||
{ id: 5, label: 'Node 5', title: 'I have a popup!' }, | |||
{ id: 6, label: 'Node 6', title: 'I have a popup!' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tav0, so I tested this new example data on master (without the fix) and I am not able to reproduce the bug. can you tell me more about when you see the bug (see hover broken)?
Could you perhaps add another example to the PR that will show the bug if the fix is not present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some more details on what I tried in this issue #51
Hi @micahstubbs sorry for the delay, here it is a gif of the issue. (master branch) |
nice, thanks for adding the example! I'll take a look at this, hopefully sometime this week. |
hi @Tav0, so checked out your branch git checkout -b Tav0-fix/hover-orphan-node master
git pull https://github.com/Tav0/visjs-network.git fix/hover-orphan-node and saw this:
|
@Tav0 could you take another look, and see if you can produce an example where 3) works too? |
@Tav0 let's keep at this - I think we are close to a solution here 😄 📈 |
will close this PR, since I was not able to reproduce the fix. @Tav0 please do re-open this PR if you would like to help us verify the fix 😄 |
fix #51