package.json: fix "types" path

[tharvik]

Current release do not correclty reference type declarations in package.json. Using the index.d.ts from peer fixes it.

btw, can you please do a new NPM release when merged, as published version is not usable from TypeScript.

[tharvik]

Hum, the build are failing as vis-dev-utils expect the type path to explicitly be declarations/index.d.ts, it would need a fix there also but keeping the two in sync might more easily be done by a maintainer.

[Thomaash]

Hi @tharvik,

could you tell me what exactly you're doing? Because declarations/index.d.ts corresponds to vis-graph3d and peer/index.d.ts to vis-graph3d/peer. They're not the same.

[tharvik]

Hello @Thomaash,

could you tell me what exactly you're doing?

declarations/index.d.ts doesn't exists in the 6.0.0 NPM archive so tsc fails to compile in strict mode.

#!/bin/sh -eu

mkdir vis && cd vis

npm init --yes
npm install typescript vis-graph3d

cat > index.ts <<EOF
import { Graph3d } from 'vis-graph3d'
EOF

npx tsc --strict index.ts

gives me

index.ts:1:25 - error TS7016: Could not find a declaration file for module 'vis-graph3d'. '[...]/vis/node_modules/vis-graph3d/peer/umd/vis-graph3d.js' implicitly has an 'any' type.
  Try `npm install @types/vis-graph3d` if it exists or add a new declaration (.d.ts) file containing `declare module 'vis-graph3d';`

Because declarations/index.d.ts corresponds to vis-graph3d and peer/index.d.ts to vis-graph3d/peer. They're not the same.

Ho, I though it was as most field in the package.json reference peer, what's the difference then?
I tried with import { Graph3d } from 'vis-graph3d/peer' and it works, but I find it weird to mix import { DataSet } from 'vis-data' (no /peer) with the peer import. Maybe that's intented?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[tharvik]

@Thomaash I still have the same issue, what can I do to help with it?

[vis-bot]

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀