-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Gephi parser into TypeScript #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TS pull-requests are really terrible to review.
You could try a git mv gephiParser.js gephiParser.ts
and than do the changes? No idea if this works but atm these files are hard to review and we loose a git history of these files 😢
I tried it. |
But could you not just move/rename the file than commit it and than start changing using new commits? (I'f never done that. I'm just curious!) |
I did it. It works if you go commit by commit. If you want to see the entire thing it breaks anyway. |
But without the |
But with it too. I tried to retain the history, Git just loses track once the changes are too big. And they will be too big if you squash this PR. |
Thanks for clarifying! |
No problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Apart from obvious this also includes a bugfix:
options.edges.inheritColor
was originally read asoptions.inheritColor
and therefore ignored.