Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Object doesn't support property or method 'remove' #253

Closed
namiskuukkel opened this issue Jan 15, 2020 · 3 comments · Fixed by #267
Closed

IE11: Object doesn't support property or method 'remove' #253

namiskuukkel opened this issue Jan 15, 2020 · 3 comments · Fixed by #267
Assignees
Labels
bug Something isn't working released

Comments

@namiskuukkel
Copy link

This error is triggered from vis-timeline/lib/timeline/component/item/BoxItem.js function hide(), row 274. Function is triggered upon call to setSelection.

@yotamberk yotamberk added the bug Something isn't working label Jan 18, 2020
@yotamberk
Copy link
Member

Please add a jsbin so I can reproduce the problem

@namiskuukkel
Copy link
Author

Mmm sorry, I can't really use my work time to produce an example and I can't submit a part of my actual project. However, it's quite obvious that this is broken, because IE simply doesn't support calling .remove() on the DOM object itself. The breaking change was made in commit 9fc7c3d. The previous way, element.parentNode.removeChild(element), was IE compliant.

yotamberk added a commit that referenced this issue Jan 25, 2020
@yotamberk yotamberk self-assigned this Jan 25, 2020
yotamberk added a commit that referenced this issue Jan 27, 2020
yotamberk added a commit that referenced this issue Jan 27, 2020
@vis-bot
Copy link
Collaborator

vis-bot commented Jan 27, 2020

🎉 This issue has been resolved in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants