Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vis.DataSet _idProp instead of _fieldId #97

Closed
jasonex7 opened this issue Sep 16, 2019 · 0 comments · Fixed by #98
Closed

Using vis.DataSet _idProp instead of _fieldId #97

jasonex7 opened this issue Sep 16, 2019 · 0 comments · Fixed by #98

Comments

@jasonex7
Copy link
Contributor

jasonex7 commented Sep 16, 2019

I see that vis.DataSet defines _idProp with fieldId configuration option, but vis.Timeline uses _fieldId which is always undefined. vis.Timeline should use _idProp too.

vis.DataSet definition of _idProp:
https://github.com/visjs/vis-data/blob/3e86bc0c55425476b803412e9cea207f0e075a67/src/data-set.ts#L173

Example of vis.Timeline using _fieldId:

const id = util.randomUUID();
itemData[this.itemsData._fieldId] = id;

@jasonex7 jasonex7 changed the title Using vis.DataSet _propId instead of _fieldId Using vis.DataSet _idProp instead of _fieldId Sep 16, 2019
jasonex7 added a commit to jasonex7/vis-timeline that referenced this issue Sep 16, 2019
yotamberk pushed a commit that referenced this issue Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant