-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more options to control the length of normals in MeshNormals visual #2043
Conversation
Would it be possible for you to add a test? Also, what about some examples like the ones you listed in this PR's description but in an
And so on. Thoughts? |
I will look at that next.
Good idea. I had a try.
I was thinking about making it more convenient to use this with a MeshVisual. Currently mesh = MeshVisual(...)
normals = MeshNormals(mesh.mesh_data, ...) Two ideas:
With option 1, it is obvious where to configure the normals, at construction time or through |
@djhoese In the tests, I set up a camera instead of defining the scene transformations manually. It seems simpler to maintain in my opinion. Is there maybe another reason for the manual transformations instead? |
The error is when initializing the /usr/bin/bash -c source /home/runner/.bash_profile && micromamba list
ERROR Cannot activate, prefix does not exist at: /home/runner/micromamba/envs/vispy-tests
Error: The process '/usr/bin/bash' failed with exit code 1 I don't see at first how this could be linked to the last commit. |
@asnt Looks like a spurious thing. Maybe just rerun it will help? |
Thanks @kmuehlbauer . I don't think I can relaunch the tests. Let's see with the new commit. |
Revert mistake. The mesh is necessary. This reverts commit 4fd6e5e.
@djhoese The tests now cover all parameters. For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good. Nice job on the tests. One request: could you have the first Example in your docstring show you creating the Mesh visual and passing the meshdata instance to the normals visual?
Use cases: