Add filter keyword arguments to subclassed filters #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
approved these changes
Jul 16, 2021
|
@almarklein @kmuehlbauer what's your opinion on a change like this being a bug fix or a feature? Most importantly should it go in 0.7.2 or 0.8.0? |
|
No strong opinion, but I would tend to bug fix. |
|
That works for me Kai, thanks. @clarebcook thanks again for fixing this. Let's merge it and plan to include it in a 0.7.2 release in the next week or two. |
|
Wonderful, thank you! |
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow users to pass keyword arguments to the subclassed filters in
color.py.Closes #2143