-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve PySide6 Support: swapBehavior for DoubleBuffer, BUTTONMAP as pyqt6, xfail test_context #2411
Conversation
So this drops support for older PySide versions (6.1 and 6.2 most likely), this is OK with me. With this single change to the |
pyside6 6.2 is still fine. the only question is 6.0 and 6.1. I can't install those or find any docs on them.
|
That's probably an update needed here: vispy/vispy/app/backends/_qt.py Line 194 in 8bf4f9e
|
Thanks for the tip! I went through everywhere there is I also added pyside6 to the xfails for shared context, so now the app tests can run without set fault on pyside6 (note that run individually, |
Thanks @psobolewskiPhD! |
Fixes #2407 by using
SwapBehavior
to set DoubleBufferPYSIDE6_API is included in the existing PYQT6_API logic:
vispy/vispy/app/backends/_qt.py
Lines 281 to 287 in 8bf4f9e
This should work for PySide6 going back to at least 6.2 (LTS)
I found the Qt 6.2 (LTS) docs. The swap behavior was already present.
https://doc.qt.io/qt-6.2/qsurfaceformat.html#SwapBehavior-enum
https://doc.qt.io/qtforpython-6.2/PySide6/QtGui/QSurfaceFormat.html#PySide6.QtGui.PySide6.QtGui.QSurfaceFormat.SwapBehavior
Edit: Also uses the same BUTTONMAP as PyQT6
Plus, xfails the shared context tests: test_context.py
Fixes #2410